Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Vue.component('RouterLink') is undefined in vue-router 3.0.0 #4668

Merged
merged 1 commit into from
Jan 2, 2019

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Jan 2, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)

Checklist:

  • All new and existing tests are passing.

@clarkdo clarkdo requested a review from Atinux January 2, 2019 10:22
@clarkdo clarkdo changed the title fix: Vue.component(RouterLink) is undefined in vue-router 3.0.0 fix: Vue.component('RouterLink') is undefined in vue-router 3.0.0 Jan 2, 2019
@codecov-io
Copy link

Codecov Report

Merging #4668 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #4668   +/-   ##
=======================================
  Coverage   90.82%   90.82%           
=======================================
  Files          67       67           
  Lines        2223     2223           
  Branches      543      543           
=======================================
  Hits         2019     2019           
  Misses        185      185           
  Partials       19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b210724...d539a7e. Read the comment docs.

@manniL
Copy link
Member

manniL commented Jan 2, 2019

But they are installed as PascalCase versions 🤔
(see https://github.com/vuejs/vue-router/blob/dev/src/install.js#L46-L47)

@clarkdo
Copy link
Member Author

clarkdo commented Jan 2, 2019

@manniL It's not in 3.0.0 https://github.com/vuejs/vue-router/blob/v3.0.0/src/install.js#L46-L47 😄

@manniL
Copy link
Member

manniL commented Jan 2, 2019

@clarkdo Omg 🙈
Thanks, you are right 😅

This is fixed in 3.0.2 though as it seems

@Atinux Atinux merged commit 7ff4058 into nuxt:dev Jan 2, 2019
pi0 pushed a commit that referenced this pull request Jan 2, 2019
@clarkdo clarkdo deleted the routerlink-null branch April 2, 2019 13:14
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants