Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): don't mutate options export #5865

Merged
merged 1 commit into from
Jun 4, 2019
Merged

fix(cli): don't mutate options export #5865

merged 1 commit into from
Jun 4, 2019

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jun 4, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Don't directly mutate the exported object from nuxt.config.js.

fixes #5840 and a workaround for standard-things/esm#813

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@pi0 pi0 mentioned this pull request Jun 4, 2019
@codecov-io
Copy link

codecov-io commented Jun 4, 2019

Codecov Report

Merging #5865 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #5865      +/-   ##
==========================================
+ Coverage   95.72%   95.72%   +<.01%     
==========================================
  Files          82       82              
  Lines        2690     2691       +1     
  Branches      690      690              
==========================================
+ Hits         2575     2576       +1     
  Misses         97       97              
  Partials       18       18
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.35% <0%> (-0.02%) ⬇️
#unit 92.71% <100%> (ø) ⬆️
Impacted Files Coverage Δ
packages/cli/src/utils/config.js 93.75% <100%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2c0889...42284ac. Read the comment docs.

@atinux atinux self-requested a review June 4, 2019 14:08
Copy link
Member

@atinux atinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yarn generate failing
5 participants