Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.8.1 #5866

Merged
merged 11 commits into from
Jun 4, 2019
Merged

v2.8.1 #5866

merged 11 commits into from
Jun 4, 2019

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jun 4, 2019

🐛 Bug Fixes

💅 Refactors

💖 Thanks to

  • Rafał Chłodnicki (@rchl)

@pi0 pi0 requested a review from a team June 4, 2019 15:38
@kevinmarrec
Copy link
Contributor

kevinmarrec commented Jun 4, 2019

Dunno if we can also ship #5854 as it's ready, but it's also fine if it only lands in next patch or next minor. (Don't remember how refactor keyword is handled by semver, might be minor version)

@pi0
Copy link
Member Author

pi0 commented Jun 4, 2019

@kevinmarrec Refactor is safe to be in a patch. But do you think releasing just these changes would be useful for users? (Without also moving leftovers to the module)

@kevinmarrec
Copy link
Contributor

kevinmarrec commented Jun 4, 2019

@pi0 No but you can look my draft PR which remove TypeScript support from core and it's kind of lot of changes, it will make easier to review if we can merge this first part before.

EDIT : It feels better seperating refactor & swap to module than having the refactor with the swap.

@codecov-io

This comment has been minimized.

@pi0 pi0 merged commit ad42d85 into 2.x Jun 4, 2019
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants