Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement setupTimeout option in test-utils #14159

Closed
BracketJohn opened this issue Jun 14, 2022 · 1 comment · Fixed by nuxt/framework#7866
Closed

implement setupTimeout option in test-utils #14159

BracketJohn opened this issue Jun 14, 2022 · 1 comment · Fixed by nuxt/framework#7866

Comments

@BracketJohn
Copy link
Contributor

Environment

Nuxt CLI v3.0.0-rc.4-27585508.c9d4b2e                                                                                                                                               12:42:59
RootDir: /app                                                                                                                  
Nuxt project info:                                                                                                                                                                 

------------------------------
- Operating System: `Darwin`
- Node Version:     `v16.14.2`
- Nuxt Version:     `3.0.0-rc.4-27585508.c9d4b2e`
- Package Manager:  `npm@8.5.0`
- Builder:          `vite`
- User Config:      `typescript`, `build`, `nitro`
- Runtime Modules:  `-`
- Build Modules:    `-`
------------------------------

Reproduction

Repo: https://github.com/nuxt/framework

Describe the bug

setupTimeout seems to do nothing, checking the codebase of this repo I cannot find setupTimeout or setupTest anywhere besides in the docs + the options object:

Additional context

Testing using the test-utils takes quite long right now - 30 - 60 seconds of setup time. I wanted to reduce this and one guess of mine was that the setupTimeout can help with that. Upon further investigation I could not find it doing anything.

Let me know if this is actually a flaw, I'd be open to remove this part from the docs or extend code to apply setupTimeout.

Logs

No response

@BracketJohn BracketJohn changed the title setupTimeout of test-utils seems to do nothing setupTimeout of test-utils seems to have no effect Jun 14, 2022
@danielroe danielroe changed the title setupTimeout of test-utils seems to have no effect implement setupTimeout option in test-utils Jun 14, 2022
Copy link
Member

cc: @antfu

@danielroe danielroe added the bug label Sep 20, 2022 — with Volta.net
@danielroe danielroe self-assigned this Sep 27, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
@danielroe danielroe transferred this issue from nuxt/framework Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants