Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add resolvedLayouts to support class components in layouts #1310

Merged
merged 2 commits into from Aug 13, 2017

Conversation

whtsky
Copy link

@whtsky whtsky commented Aug 7, 2017

Fixes #800 .
PR #1299 works great for development environments, but in production build VueComponent name got mangled thus will not work.

@codecov-io
Copy link

Codecov Report

Merging #1310 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1310   +/-   ##
=======================================
  Coverage   93.03%   93.03%           
=======================================
  Files          12       12           
  Lines         747      747           
=======================================
  Hits          695      695           
  Misses         52       52

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c527c2...e686844. Read the comment docs.

@dojineko
Copy link

dojineko commented Aug 7, 2017

@whtsky very nice! 👍

@Atinux Atinux merged commit 233ea26 into nuxt:dev Aug 13, 2017
@Atinux
Copy link
Member

Atinux commented Aug 13, 2017

Thank you @whtsky

Will be in rc5

@lock
Copy link

lock bot commented Nov 1, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 1, 2018
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when I use typescript in layout file, error raise on page reload.
5 participants