Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add example for accessing vite config programmatically #18812

Merged
merged 8 commits into from Jul 30, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

#14534

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR adds docs for an example way to access configuration information using Nuxt Kit utilities.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Feb 6, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

Co-authored-by: Damian GΕ‚owala <48835293+DamianGlowala@users.noreply.github.com>
@pi0
Copy link
Member

pi0 commented Feb 6, 2023

As we are documenting the usage and there are some valid use cases, I believe we should still expose it as a @nuxt/kit utility. At least managing and unifying the workarounds behind it.

@floroz
Copy link

floroz commented Feb 6, 2023

Thank you @danielroe for exposing this documentation.

I am on nuxt@3.1.2 and I get a TS error for the signature of the option of loadNuxt

Screenshot 2023-02-06 at 14 26 00

Type '{ cwd: string; dev: false; ssr: boolean; }' is not assignable to type 'LoadNuxtOptions'.
  Object literal may only specify known properties, and 'ssr' does not exist in type 'LoadNuxtOptions'.

@danielroe
Copy link
Member Author

@floroz Thanks for catching that - fixed βœ…

@danielroe danielroe added the 3.x label Feb 6, 2023
@danielroe danielroe merged commit fc10da3 into main Jul 30, 2023
3 checks passed
@danielroe danielroe deleted the docs/vite-config branch July 30, 2023 09:17
@github-actions github-actions bot mentioned this pull request Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants