Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): exclude nitro output dir from type checking #19532

Merged
merged 3 commits into from Mar 8, 2023
Merged

fix(nuxt): exclude nitro output dir from type checking #19532

merged 3 commits into from Mar 8, 2023

Conversation

productdevbook
Copy link
Sponsor Member

@productdevbook productdevbook commented Mar 8, 2023

Thank you danielroe back message

 "exclude": [
    "../dist",
    "../.output"
  ]
  

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Mar 8, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

tsconfig.json Outdated Show resolved Hide resolved
@danielroe danielroe changed the title fix: exclude nitro output dir from typescript fix(nuxt): exclude nitro output dir from type checking Mar 8, 2023
@danielroe
Copy link
Member

TypeScript will exclude dotted directories anyway (e.g. .output) but in case the user has set a custom one, this seems like a good change to me. πŸ‘Œ

@danielroe danielroe merged commit 17f080c into nuxt:main Mar 8, 2023
@danielroe danielroe mentioned this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants