fix(kit): add legacy entrypoints for pre v3.3 usage #19874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pi0
reviewed
Mar 23, 2023
Merged
pi0
reviewed
Mar 24, 2023
| @@ -8,7 +8,8 @@ | |||
| "exports": { | |||
| ".": { | |||
| "types": "./dist/index.d.ts", | |||
| "import": "./dist/index.mjs" | |||
| "import": "./dist/index.mjs", | |||
| "require": "./dist/index.mjs" | |||
There was a problem hiding this comment.
This is unsafe especially that i constantly see modules wrongly build with .cjs in dist and actually do require('@nuxt/kit') but seems we don't have any choice at least until patched versions of nuxt 3 are widely adapted...
There was a problem hiding this comment.
oh, this is terrible, I agree. But I think require shouldn't work in any case, as we have type: "module"
pi0
approved these changes
Mar 24, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#19717
❓ Type of change
📚 Description
In various cases users on projects pre-3.3 who are consuming a 3.3 kit may receive an error message (because previously we were using cjs resolve utilities to resolve kit.
For example: nuxt/nuxt.new#55.
This adds backward compatibility for those previous projects.
📝 Checklist