Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add js payload test suite #20217

Merged
merged 2 commits into from
Apr 11, 2023
Merged

test: add js payload test suite #20217

merged 2 commits into from
Apr 11, 2023

Conversation

danielroe
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This adds a test suite for the (current default) JS payload to prevent regressions now that we are focusing development on JSON payload rendering.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe self-assigned this Apr 11, 2023
@codesandbox
Copy link

codesandbox bot commented Apr 11, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe danielroe marked this pull request as ready for review April 11, 2023 22:46
@danielroe danielroe requested a review from manniL April 11, 2023 22:46
@danielroe danielroe merged commit 67ca081 into main Apr 11, 2023
@danielroe danielroe deleted the chore/payload-tests branch April 11, 2023 22:57
@danielroe danielroe mentioned this pull request Apr 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manniL manniL Awaiting requested review from manniL

Assignees

@danielroe danielroe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@danielroe