docs: add warning about redirect check #20680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Live Preview ready!
|
GalacticHypernova
changed the title
danielroe
reviewed
May 4, 2023
|
Oops, didn't know what re-requesting review button would do |
danielroe
requested changes
May 8, 2023
There was a problem hiding this comment.
Let's keep the current to.path rather than from.path but we can add a comment along the lines of:
// in a real app you would probably not redirect every route to `/`
// but it is important to check `to.path` before redirecting or you
// may cause an infinite redirect loop
|
Sure thing! |
danielroe
reviewed
Jun 12, 2023
danielroe
reviewed
Jun 12, 2023
danielroe
reviewed
Jun 12, 2023
danielroe
reviewed
Jun 12, 2023
danielroe
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Fixes #20678
❓ Type of change
📚 Description
This PR fixes multiple issues with the newly merged docs, such as to.path usage in route guards (in stead of from.path, because we don't want to force people onto a specific route, the goal is to avoid infinite redirects). Also, this fixes an undefined variable 'user' in the "err as a String" section of the api/utils/abort-navigation page.
📝 Checklist