feat(nuxt): sync useCookie state (including between tabs)
#20970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Live Preview ready!
|
…nuxt into fix/shared-cookie-state
|
Updated it to use BroadcastChannel API. Now it is synced across tabs and we don't need new Nuxt events. |
|
@danielroe can you please take a look and review, thx |
danielroe
reviewed
Jun 5, 2023
danielroe
reviewed
Jun 5, 2023
|
@xanderbarkhatov thx well done... @danielroe can you please review? |
|
@c-schwan You do not need to ping me to review. |
danielroe
approved these changes
Jun 6, 2023
pi0
approved these changes
Jun 6, 2023
| @@ -34,9 +34,28 @@ export function useCookie<T = string | null | undefined> (name: string, _opts?: | |||
| const cookie = ref<T | undefined>(cookies[name] as any ?? opts.default?.()) | |||
|
|
|||
| if (process.client) { | |||
| const callback = () => { writeClientCookie(name, cookie.value, opts as CookieSerializeOptions) } | |||
| const channel = new BroadcastChannel(`nuxt:cookies:${name}`) | |||
There was a problem hiding this comment.
However, there is small percentage of browsers not supporting this API, i would add a check guard if feature is not available.
danielroe
changed the title
useCookie stateuseCookie state between tabs
Merged
|
Um, and how it resolved issues when two components in same tab use |
|
They are synced even within the same tab. |
antfu
pushed a commit
that referenced
this pull request
Jun 7, 2023
|
I guess your title is a little bit confusing) |
danielroe
changed the title
useCookie state between tabsuseCookie state (including between tabs)
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #13020
❓ Type of change
📚 Description
Use BroadcastChannel API to sync state across
useCookieinvocations📝 Checklist