Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): replace BigInt literal with BigInt constructor #21427

Merged
merged 2 commits into from Jun 7, 2023

Conversation

AWBroch
Copy link
Contributor

@AWBroch AWBroch commented Jun 7, 2023

πŸ”— Linked issue

#21416 BigInt literal breaks transpilation for non-ES2022 targets

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Replaces BigInt literal with BigInt constructor function because the BigInt literal syntax doesn’t support being transpiled to browsers that don’t support it, like Safari 12 and 13. Using the BigInt constructor the code transpiles properly, it will just fail if you try to use BigInt in a browser that doesn’t support it.
Resolves #21416

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe merged commit 0bc38b7 into nuxt:main Jun 7, 2023
22 checks passed
@github-actions github-actions bot mentioned this pull request Jun 7, 2023
@AWBroch AWBroch deleted the patch-1 branch June 7, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigInt literal from #21257 breaks transpilation for non-ES2022 targets
2 participants