Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(nuxt): extract and apply plugin order at build time #21611

Merged
merged 16 commits into from Jun 19, 2023

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Jun 17, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

When we introduced object-syntax plugins, we highlighted that this might be extracted at build-time.

This plugin implements a build-time step to extract plugin metadata, and also normalise plugins at build-time.

This slightly reduces the work that needs to be done on Nuxt app hydration.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@huang-julien
Copy link
Member

BTW it seems that using the devtools completly breaks the dev server at this line
image

[nuxt] [request error] [unhandled] [500] plugin.apply is not a function

Copy link
Member

@huang-julien huang-julien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

@danielroe danielroe merged commit 2abcc16 into main Jun 19, 2023
22 checks passed
@danielroe danielroe deleted the perf/build-time-plugin-meta branch June 19, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants