Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): use esbuild/acorn instead of typescript dep #21729

Merged
merged 3 commits into from Jun 23, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #21723

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This moves us away from using @typescript-eslint/typescript-estree which needs typescript as a peerDep. Esbuild + acorn are already dependencies so this doesn't add anything extra to the bundle.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe merged commit 789c8bf into main Jun 23, 2023
28 checks passed
@danielroe danielroe deleted the fix/esbuild-transform branch June 23, 2023 23:01
@github-actions github-actions bot mentioned this pull request Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v3.6] Cannot find module 'typescript' on prepare stage
2 participants