Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): remove @vue/ scoped libraries from resolutions #21922

Merged
merged 5 commits into from Jul 4, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

reverts #20829
#14146 (comment)

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Technically any packages in optimizeDeps.include and dedupe need to be resolvable from the dependencies of the root package.json. So the current setup is incompatible with disabling shamefully-hoist. By removing these packages, we make it possible not to have to to install all the @vue scoped libraries.

In addition, this PR also adds nitro dependencies to the external array so that nitro can better handle resolving them as part of its build process (possibly deduping them with them being used in server routes).

When unjs/nitro#1388 is merged, we can then move the transpile call from vite/webpack server builds directly into nitro options.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Jul 3, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe requested a review from antfu July 3, 2023 21:22
@danielroe danielroe merged commit 9585620 into main Jul 4, 2023
28 checks passed
@danielroe danielroe deleted the fix/vite-resolve branch July 4, 2023 07:27
@github-actions github-actions bot mentioned this pull request Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants