Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): regenerate imports after template #21934

Merged
merged 1 commit into from Jul 5, 2023

Conversation

antfu
Copy link
Member

@antfu antfu commented Jul 4, 2023

πŸ”— Linked issue

fixes #18897

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Jul 4, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@antfu
Copy link
Member Author

antfu commented Jul 4, 2023

It's just an assumption, @lihbr if you have time, it would be great if you can help verify whether it fixes.

@lihbr
Copy link
Member

lihbr commented Jul 4, 2023

First thing tomorrow!

@lihbr
Copy link
Member

lihbr commented Jul 5, 2023

Yep, this is it!

Tried before/after on the playground, before the bug happens as described in the issue, now I cannot reproduce it, even after dozens of changes πŸš€

@danielroe danielroe merged commit 28e91a7 into main Jul 5, 2023
28 checks passed
@danielroe danielroe deleted the fix/regenerate-import-timing branch July 5, 2023 09:25
@antfu
Copy link
Member Author

antfu commented Jul 5, 2023

Thanks a lot @lihbr!

@github-actions github-actions bot mentioned this pull request Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Composable auto-imports break when modified, useXXX is not defined (pnpm run dev/npm run dev)
3 participants