Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix auto-import differences for composables and components folder #22062

Merged
merged 6 commits into from Jul 10, 2023
Merged

docs: fix auto-import differences for composables and components folder #22062

merged 6 commits into from Jul 10, 2023

Conversation

EduSantosBrito
Copy link
Contributor

๐Ÿ”— Linked issue

#22056

โ“ Type of change

  • ๐Ÿ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • ๐Ÿž Bug fix (a non-breaking change that fixes an issue)
  • ๐Ÿ‘Œ Enhancement (improving an existing functionality like performance)
  • โœจ New feature (a non-breaking change that adds functionality)
  • ๐Ÿงน Chore (updates to the build process or auxiliary tools and libraries)
  • โš ๏ธ Breaking change (fix or feature that would cause existing functionality to change)

๐Ÿ“š Description

Currently the documentation is not explaining about the differences to disable auto-import for the composables and components folder. Added the information based on @danielroe comments (Thanks for the explanation ๐Ÿ˜„).

๐Ÿ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Jul 10, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@nuxt-studio
Copy link

nuxt-studio bot commented Jul 10, 2023 •
edited

โœ… Live Preview ready!

Name Edit Preview Latest Commit
Nuxt Docs Edit on Studio โ†—๏ธŽ View Live Preview 18c2a6f

@danielroe
Copy link
Member

Thank you! Love the quick action to make the docs better โค๏ธ

DamianGlowala
DamianGlowala requested changes Jul 10, 2023
View reviewed changes
docs/2.guide/1.concepts/1.auto-imports.md Outdated Show resolved Hide resolved
docs/2.guide/1.concepts/1.auto-imports.md Outdated Show resolved Hide resolved
docs/2.guide/1.concepts/1.auto-imports.md Outdated Show resolved Hide resolved
docs/2.guide/1.concepts/1.auto-imports.md Outdated Show resolved Hide resolved
docs/2.guide/1.concepts/1.auto-imports.md Outdated Show resolved Hide resolved
Atinux and others added 3 commits July 10, 2023 14:31
@Atinux @DamianGlowala
Update docs/2.guide/1.concepts/1.auto-imports.md
9674724 
Co-authored-by: Damian Gล‚owala <48835293+DamianGlowala@users.noreply.github.com>
@Atinux @DamianGlowala
Update docs/2.guide/1.concepts/1.auto-imports.md
966acba 
Co-authored-by: Damian Gล‚owala <48835293+DamianGlowala@users.noreply.github.com>
@Atinux @DamianGlowala
Apply suggestions from code review
18c2a6f 
Co-authored-by: Damian Gล‚owala <48835293+DamianGlowala@users.noreply.github.com>
@danielroe danielroe merged commit bf7e96c into nuxt:main Jul 10, 2023
2 checks passed
@github-actions github-actions bot mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DamianGlowala DamianGlowala DamianGlowala requested changes

@Atinux Atinux Atinux approved these changes

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@EduSantosBrito @danielroe @Atinux @DamianGlowala