Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli,schema): add bundler module resolution flag #22142

Merged
merged 4 commits into from Jul 14, 2023

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Jul 14, 2023

πŸ”— Linked issue

unjs/nitro#1384, #20629,

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This adds a corresponding 'bundler' module resolution option for nuxt, which also sets the nitro option by default.

This is now the recommended setting. New projects are recommended to start with this turned on, and in a future minor release of Nuxt it will become the default setting.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Jul 14, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe changed the title feat(cli,schema): add experimental bundler module resolution flag refactor(cli,schema): add experimental bundler module resolution flag Jul 14, 2023
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice πŸ’š I think we can move forward without waiting for nitro release.

Also, feel free to backport improvements to upstream (case normalization, typescript infer, env variable)

@danielroe danielroe changed the title refactor(cli,schema): add experimental bundler module resolution flag refactor(cli,schema): add bundler module resolution flag Jul 14, 2023
@danielroe danielroe merged commit a07cfb8 into main Jul 14, 2023
28 checks passed
@danielroe danielroe deleted the feat/experimental-bundler-mode branch July 14, 2023 13:46
@github-actions github-actions bot mentioned this pull request Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants