Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: experimental.typescriptBundlerResolution flag #1384

Merged
merged 1 commit into from
Jul 14, 2023
Merged

feat: experimental.typescriptBundlerResolution flag #1384

merged 1 commit into from
Jul 14, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This likely needs to be released carefully, but we should eventually move to new 'Bundler' module resolution, which supports types in subpath imports and more exactly models how rollup will resolve imports.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added enhancement New feature or request breaking change labels Jul 3, 2023
@danielroe danielroe requested a review from pi0 July 3, 2023 15:13
@danielroe danielroe self-assigned this Jul 3, 2023
@pi0 pi0 changed the title fix!: use new 'bundler' module resolution feat(types)!: use new 'bundler' module resolution Jul 3, 2023
@pi0
Copy link
Member

pi0 commented Jul 3, 2023

Shall we release it as new future|experimental.typescriptBundler flag option? Both Nitro and Nuxt can enable bundler resolution when enabled.

Copy link
Member Author

Makes sense πŸ‘

Do you have preference for API name?

@pi0
Copy link
Member

pi0 commented Jul 3, 2023

You speak native English so i trust you on this :D Since we might end-up supporting it as a Nuxt flag too, probably experimental. namespace is best.

@pi0 pi0 changed the title feat(types)!: use new 'bundler' module resolution feat(types): experimental bundler module resolution flag Jul 14, 2023
@pi0 pi0 changed the title feat(types): experimental bundler module resolution flag feat: experimental.typescriptBundlerResolution flag Jul 14, 2023
@pi0 pi0 merged commit fd9a9ee into main Jul 14, 2023
9 checks passed
@pi0 pi0 deleted the fix/bundler branch July 14, 2023 12:48
@pi0 pi0 mentioned this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants