Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): ensure we only increment hydrating count once #22200

Merged
merged 1 commit into from Jul 18, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #22022

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

In some cases, vue router can end up re-executing the render cycle of a component more than once in hydration. In this case, we can avoid incrementing the hydration counter by moving it out of the render function and into setup, which is also a performance improvement.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Jul 18, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe requested a review from antfu July 18, 2023 15:08
@danielroe danielroe merged commit 449a015 into main Jul 18, 2023
28 checks passed
@danielroe danielroe deleted the fix/spa-hydration branch July 18, 2023 15:21
This was referenced Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cached pages fail to run async calls when ssr is false
2 participants