Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(nuxt,schema): do not watch buildDir and node_modules #22214

Merged
merged 17 commits into from Jul 19, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

unjs/nitro#1458, #20213

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This follows up some earlier fixes to the watching implementation for Nuxt, which will particularly affect Linux and Windows machines. There are two issues fixed here as well as a third potential issue:

  1. we were adding .nuxt and .nuxt/analyze in their absolute form which were ignored, meaning we were watching the build directory 😱
  2. we were not ignoring node_modules within layers, only at the top level 😱
  3. we have also added additional output directories like .vercel, .netlify and dist, as well as excluding .output, .git and .cache even when these are within subdirectories. (There has been no explicit report that this fixes, but I think it should be safe and improve performance.)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Jul 19, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe merged commit 0f16cd6 into main Jul 19, 2023
28 checks passed
@danielroe danielroe deleted the fix/quis-custodiet branch July 19, 2023 14:43
This was referenced Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants