New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(nuxt,schema): do not watch buildDir
and node_modules
#22214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
antfu
approved these changes
Jul 19, 2023
antfu
reviewed
Jul 19, 2023
antfu
reviewed
Jul 19, 2023
pi0
reviewed
Jul 19, 2023
manniL
approved these changes
Jul 19, 2023
pi0
approved these changes
Jul 19, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
unjs/nitro#1458, #20213
β Type of change
π Description
This follows up some earlier fixes to the watching implementation for Nuxt, which will particularly affect Linux and Windows machines. There are two issues fixed here as well as a third potential issue:
.nuxt
and.nuxt/analyze
in their absolute form which were ignored, meaning we were watching the build directory π±node_modules
within layers, only at the top level π±.vercel
,.netlify
anddist
, as well as excluding.output
,.git
and.cache
even when these are within subdirectories. (There has been no explicit report that this fixes, but I think it should be safe and improve performance.)π Checklist