Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): access resolved scrollBehaviorType #22264

Merged
merged 1 commit into from Jul 21, 2023
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

#21948
https://github.com/nuxt/ecosystem-ci/actions/runs/5618792731/job/15224930143

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

We are accessing this.scrollBehaviorType but this is not accessible if the user has provided their own router config. Instead we can access it from the resolved router options.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Jul 21, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe
Copy link
Member Author

/ecosystem-ci run nuxt-vitest

@nuxt-ecosystem-ci
Copy link

nuxt-ecosystem-ci bot commented Jul 21, 2023

πŸ“ Ran ecosystem CI: Open

suite result
nuxt-vitest ❌ failure

@danielroe danielroe merged commit 429d365 into main Jul 21, 2023
29 checks passed
@danielroe danielroe deleted the fix/scroll-behavior branch July 21, 2023 09:17
@github-actions github-actions bot mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants