Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): components auto-import for JSX #22330

Merged
merged 2 commits into from Jul 26, 2023

Conversation

antfu
Copy link
Member

@antfu antfu commented Jul 26, 2023

πŸ”— Linked issue

fix #14862

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Jul 26, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@antfu antfu marked this pull request as ready for review July 26, 2023 02:36
@danielroe danielroe merged commit e3437c6 into main Jul 26, 2023
29 checks passed
@danielroe danielroe deleted the fix/components-auto-import-tsx branch July 26, 2023 04:30
@github-actions github-actions bot mentioned this pull request Jul 26, 2023
@xalteropsx
Copy link

@antfu it still doesnt solve multi export from single jsx file

@xalteropsx
Copy link

xalteropsx commented Dec 2, 2023

image
while only it work for 1
image

@xalteropsx
Copy link

xalteropsx commented Dec 2, 2023

@danielroe is their anything u can do about multi export auto import feature? right now only default is tracked by ur auto import
image

Copy link
Member

You could open an issue to track it - I think we could support this for *.{js,ts,jsx,tsx} files πŸ™

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to resolve component: NuxtLink and ClientOnly
3 participants