perf(nuxt): write templates in single sync step + improve logs #22384
Conversation
|
|
| } | ||
| })) | ||
|
|
||
| for (const write of writes) { write() } |
There was a problem hiding this comment.
AFAIK, using sync methods, blocks (our) main js render loop but it won't speed up v8 i/o threads. Have you tried with this new batching technique ++ async Promise.all to see timing differences?
There was a problem hiding this comment.
I've done some tests but the performance benefit I'm looking for here is reducing cascading hmr rather than reducing the time required to write the files.
There was a problem hiding this comment.
Yes, I understand that main point 👍🏼 But i suppose (native) HMR watchers are not in the same event loop of main javascript process we are writing files from (unless our receiver is sync again including vite). If either method is faster, it reduces final chance to have duplicate HMR events but if you already tried both, feel free to ignore this comment :)
There was a problem hiding this comment.
it may be an unnecessary optimisation. I tried both without appreciable time difference, and flagged up the fact that we are actually not watching the buildDir with vite. I will have a look to see if we actually should be watching the directory. Not doing so might be causing some occasionally issues with vite-node cache, for example.
There was a problem hiding this comment.
I think you have a good point here and we should definitely iterate on this. I'd be very open to rethinking this if you notice any issue..
danielroe
changed the title
🔗 Linked issue
❓ Type of change
📚 Description
This PR bundles three performance-focused improvements to template compilation and writing:
📝 Checklist