Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nuxt): scroll to top by default on dynamic routes #22403

Merged
merged 18 commits into from Sep 6, 2023
Merged

fix(nuxt): scroll to top by default on dynamic routes #22403

merged 18 commits into from Sep 6, 2023

Conversation

huang-julien
Copy link
Member

@huang-julien huang-julien commented Jul 30, 2023 •
edited by danielroe

🔗 Linked issue

resolve #22402

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Hi 👋 this PR change the _isDifferentRoute from router.options.ts so routes with the same component can also get scrolled to top after page switch

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

todo

  • fixtures tests

@stackblitz
Copy link

stackblitz bot commented Jul 30, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@huang-julien huang-julien changed the title fix(nuxt): fix isDifferentRoute util in router.oiptions fix(nuxt): fix isDifferentRoute utils in router.oiptions Jul 30, 2023
@huang-julien huang-julien changed the title fix(nuxt): fix isDifferentRoute utils in router.oiptions fix(nuxt): use route.path instead of comparing matched components in _isDifferentRoute() Jul 30, 2023
@huang-julien huang-julien marked this pull request as ready for review July 30, 2023 22:04
@nuxt-studio
Copy link

nuxt-studio bot commented Aug 1, 2023 •
edited

✅ Live Preview ready!

Name Edit Preview Latest Commit
Nuxt Docs Edit on Studio ↗︎ View Live Preview eeada97

@danielroe danielroe requested a review from Atinux August 2, 2023 07:31
@danielroe danielroe changed the title fix(nuxt): use route.path instead of comparing matched components in _isDifferentRoute() fix(nuxt): scroll to top for every different path, not just ones with different components Sep 6, 2023
@danielroe danielroe changed the title fix(nuxt): scroll to top for every different path, not just ones with different components fix(nuxt): scroll to top by default on dynamic routes Sep 6, 2023
@danielroe danielroe merged commit 48fb6e2 into nuxt:main Sep 6, 2023
26 checks passed
@github-actions github-actions bot mentioned this pull request Sep 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe left review comments

@ndragun92 ndragun92 ndragun92 left review comments

@manniL manniL manniL approved these changes

@Atinux Atinux Awaiting requested review from Atinux

Assignees
No one assigned
Labels
3.x bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scroll to top is not triggered on routes with the same component.
4 participants
@huang-julien @manniL @danielroe @ndragun92