fix(kit): respect priority when registering components dirs
#22882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
danielroe
changed the title
priority when registering extra dirspriority when registering components dirs
huang-julien
approved these changes
Aug 29, 2023
Merged
imphil
added a commit
to fossi-foundation/fossi-foundation-web
that referenced
this pull request
Aug 30, 2023
Nuxt Content 2.8 fixes Vue warnings when rendering code (see also nuxt/content#2111). Update to this version. Currently, we're getting warnings in the form of " WARN [nuxt] Two component files resolving to the same name ProseP:" for all components we override. This should be fixed in an upcoming version of nuxt (nuxt/nuxt#22882).
imphil
added a commit
to fossi-foundation/fossi-foundation-web
that referenced
this pull request
Sep 5, 2023
Nuxt Content 2.8 fixes Vue warnings when rendering code (see also nuxt/content#2111). Update to this version. Currently, we're getting warnings in the form of " WARN [nuxt] Two component files resolving to the same name ProseP:" for all components we override. This should be fixed in an upcoming version of nuxt (nuxt/nuxt#22882).
imphil
added a commit
to fossi-foundation/fossi-foundation-web
that referenced
this pull request
Sep 9, 2023
Nuxt Content 2.8 fixes Vue warnings when rendering code (see also nuxt/content#2111). Update to this version. Currently, we're getting warnings in the form of " WARN [nuxt] Two component files resolving to the same name ProseP:" for all components we override. This should be fixed in an upcoming version of nuxt (nuxt/nuxt#22882).
8 tasks
imphil
added a commit
to fossi-foundation/fossi-foundation-web
that referenced
this pull request
Sep 11, 2023
Nuxt Content 2.8 fixes Vue warnings when rendering code (see also nuxt/content#2111). Update to this version. Currently, we're getting warnings in the form of " WARN [nuxt] Two component files resolving to the same name ProseP:" for all components we override. This should be fixed in an upcoming version of nuxt (nuxt/nuxt#22882).
imphil
added a commit
to fossi-foundation/fossi-foundation-web
that referenced
this pull request
Sep 13, 2023
Nuxt Content 2.8 fixes Vue warnings when rendering code (see also nuxt/content#2111). Update to this version. Currently, we're getting warnings in the form of " WARN [nuxt] Two component files resolving to the same name ProseP:" for all components we override. This should be fixed in an upcoming version of nuxt (nuxt/nuxt#22882).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #22876
❓ Type of change
📚 Description
This fixes a unintended regression from #22709. The problem wasn't in that PR, however, it was in the fact that we were relying purely on implicit directory order to register plugins.
This PR allows modules to specify a priority for an entire directory of components - but more importantly, it defaults the behaviour of
addComponentsDirto be the same asaddComponent- namely, to allow overriding.The effect of this PR does not change behaviour; it only suppresses logs when overriding a lower priority component directory, to keep this within a patch release. We can consider bigger possible changes in the next minor.
📝 Checklist