Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): find parent routes by exact path match #23040

Merged
merged 6 commits into from Sep 11, 2023
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #22977

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

It's possible to have paths that produce similarly named paths but are not really the same, for example /[[foo]].vue and /[foo].vue. These should be siblings and not create a parent/child relationship in this case.

As this is a sensitive area, I would particularly value spotting any edge cases I may have overlooked.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Sep 6, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@Hebilicious Hebilicious marked this pull request as ready for review September 6, 2023 15:38
@danielroe danielroe requested review from manniL and pi0 September 6, 2023 19:08
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Atinux Atinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@danielroe danielroe merged commit 40601ec into main Sep 11, 2023
25 checks passed
@danielroe danielroe deleted the fix/optional-child branch September 11, 2023 10:50
@github-actions github-actions bot mentioned this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional parameter route shows page of required parameter route.
3 participants