fix(nuxt): use original escapes/quotes in page re-exports #23191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
antfu
approved these changes
Sep 14, 2023
Merged
|
Amazing, thank you very much for the fix! 😍 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #15113
❓ Type of change
📚 Description
When parsing imports using
findStaticImportswe can end up with a string which has unicode escapes. When this happens, callingJSON.stringifyon it ends up double-escaping the previous escapes.I felt the best way to resolve in this particular case was to avoid re-stringifying but other ideas are welcome.
📝 Checklist