Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): provide global scope for nuxt plugin context #23667

Merged
merged 2 commits into from Oct 15, 2023
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

related: #23664
resolves #23249

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This adds a scope to global Nuxt context which has the ability to collect + cleanup before disposing of it. We can call this disposal before navigating away which allows for cleaning up cookie BroadcastChannel, for example.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Oct 13, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe requested a review from antfu October 14, 2023 07:50
@danielroe danielroe merged commit 1487c56 into main Oct 15, 2023
33 checks passed
@danielroe danielroe deleted the fix/nuxt-scope branch October 15, 2023 14:52
@github-actions github-actions bot mentioned this pull request Oct 15, 2023
@pi0
Copy link
Member

pi0 commented Oct 16, 2023

Haven't tried but really nice idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useCookie bfcache fail
3 participants