Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nuxt): allow customising defaults for data composables #23725

Merged
merged 6 commits into from Oct 18, 2023
Merged

feat(nuxt): allow customising defaults for data composables #23725

merged 6 commits into from Oct 18, 2023

Conversation

danielroe
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This allows us to set default options for useAsyncData and useFetch, including deep: false for data composables. (This will enable turning off deeply reactive responses across your app.)

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Oct 17, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@danielroe danielroe mentioned this pull request Oct 17, 2023
Merged
8 tasks
@danielroe danielroe requested review from Atinux and pi0 October 17, 2023 15:36
@danielroe danielroe marked this pull request as ready for review October 17, 2023 15:37
Base automatically changed from 10-17-feat/nuxt-link-defaults to main October 18, 2023 12:43
@danielroe danielroe mentioned this pull request Oct 18, 2023
Closed
@danielroe danielroe self-assigned this Oct 18, 2023
@danielroe danielroe changed the title feat(nuxt): allow customising defaults for data fetching composables feat(nuxt): allow customising defaults for data composables Oct 18, 2023
@danielroe danielroe merged commit 5652346 into main Oct 18, 2023
33 checks passed
@danielroe danielroe deleted the 10-17-feat/data-defaults branch October 18, 2023 14:25
@github-actions github-actions bot mentioned this pull request Oct 18, 2023
Merged
manniL pushed a commit that referenced this pull request Dec 11, 2023
@danielroe @manniL
feat(nuxt): allow customising defaults for data composables (#23725)
b09b485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

@Atinux Atinux Awaiting requested review from Atinux

Assignees

@danielroe danielroe

Labels
3.x enhancement 🍰 p2-nice-to-have
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielroe @pi0