fix(vite): don't warm up css deps and normalise urls correctly #23975
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
resolves #20533
resolves #14898
β Type of change
π Description
It seems we are over-warming up vite, and in particular warming up lots of Sass files has a significant performance cost in some projects, which is not actually needed.
This PR ensures we align our warmup logic with the upcoming warmup option in Vite 5 (vitejs/vite#14291).This PR skips warming up CSS dependencies as these are duplicate (ie. they are already included in the output of the first CSS dep). It also applies same logic for normalising URLs as Vite does itself, e.g.:
https://github.com/vitejs/vite/blob/e4c801c552edc4a60659720b89777e29eb93db6b/packages/vite/src/node/plugins/importAnalysis.ts#L604
π Checklist