Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: await before asserting console logs #24051

Merged
merged 3 commits into from Oct 31, 2023
Merged

test: await before asserting console logs #24051

merged 3 commits into from Oct 31, 2023

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Oct 31, 2023 •
edited

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This updates our test to wait a little longer before asserting what has been logged.

~~This is a PR to debug flakey CI runs that all seem to fail in the same test 🤔 ~~

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe self-assigned this Oct 31, 2023
@stackblitz
Copy link

stackblitz bot commented Oct 31, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe changed the title test: debug just nested suspense test: await before asserting console logs Oct 31, 2023
@danielroe danielroe marked this pull request as ready for review October 31, 2023 12:56
@danielroe danielroe merged commit dce8ebb into main Oct 31, 2023
35 checks passed
@danielroe danielroe deleted the test/await-logs branch October 31, 2023 12:56
@github-actions github-actions bot mentioned this pull request Oct 31, 2023
Merged
manniL pushed a commit that referenced this pull request Dec 11, 2023
@danielroe @manniL
test: await before asserting console logs (#24051)
4b1787c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@danielroe danielroe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@danielroe