Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: await before asserting console logs #24051

Merged
merged 3 commits into from Oct 31, 2023
Merged

test: await before asserting console logs #24051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ed53a4
test: debug just nested suspense
danielroe Oct 31, 2023
b128596
chore: allow only
danielroe Oct 31, 2023
433a016
test: await before asserting console logs
danielroe Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions test/basic.test.ts
View file
Open in desktop
Expand Up @@ -1200,6 +1200,8 @@ describe('nested suspense', () => {
const first = start.match(/\/suspense\/(?<parentType>a?sync)-(?<parentNum>\d)\/(?<childType>a?sync)-(?<childNum>\d)\//)!.groups!
const last = nav.match(/\/suspense\/(?<parentType>a?sync)-(?<parentNum>\d)\//)!.groups!

await new Promise<void>(resolve => setTimeout(resolve, 50))

expect(consoleLogs.map(l => l.text).filter(i => !i.includes('[vite]') && !i.includes('<Suspense> is an experimental feature')).sort()).toEqual([
// [first load] from parent
`[${first.parentType}]`,
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/basic/pages/suspense/async-[parent]/async-[child].vue
View file
Open in desktop
Expand Up @@ -3,7 +3,7 @@ if (import.meta.client) {
console.log('[async] [async]')
}
const route = useRoute('suspense-async-parent-async-child')
await new Promise(resolve => setTimeout(resolve, 500))
await new Promise(resolve => setTimeout(resolve, 50))
if (import.meta.client) {
console.log(`[async] [${route.params.parent}] [async] [${route.params.child}] running async data`)
}
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/basic/pages/suspense/sync-[parent]/async-[child].vue
View file
Open in desktop
Expand Up @@ -3,7 +3,7 @@ if (import.meta.client) {
console.log('[sync] [async]')
}
const route = useRoute('suspense-async-parent-sync-child')
await new Promise(resolve => setTimeout(resolve, 500))
await new Promise(resolve => setTimeout(resolve, 50))
if (import.meta.client) {
console.log(`[sync] [${route.params.parent}] [async] [${route.params.child}] running async data`)
}
Expand Down