Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): use consistent annotations for tree-shaking #24514

Merged
merged 1 commit into from Nov 28, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

I believe since we initially added these comments, the syntax has changed (in latest rollup). Without this change we get warnings like this:

"/*#__PURE__*/"

in "test/fixtures/basic/pages/with-computed-layout.vue" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.
test/fixtures/basic/pages/with-dynamic-layout.vue (14:1) Error when using sourcemap for reporting an error: Can't resolve original location of error.
test/fixtures/basic/pages/with-dynamic-layout.vue (14:1) A comment

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

stackblitz bot commented Nov 28, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests βœ…

❗ No coverage uploaded for pull request base (main@0f705f3). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #24514   +/-   ##
=======================================
  Coverage        ?   58.65%           
=======================================
  Files           ?        5           
  Lines           ?      861           
  Branches        ?       46           
=======================================
  Hits            ?      505           
  Misses          ?      356           
  Partials        ?        0           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@danielroe danielroe merged commit 09161d0 into main Nov 28, 2023
33 checks passed
@danielroe danielroe deleted the fix/consistent-annotations branch November 28, 2023 23:20
@github-actions github-actions bot mentioned this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants