New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(schema): avoid duplicate get
operations
#24734
Conversation
Run & review this pull request in StackBlitz Codeflow. |
I will try to get the rest handled as well, but this was the thing that caught my eye the most. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice π
Could I request this PR to not be merged until I'm done fixing all of schema? Or is it fine if it gets merged in chunks? |
Oh, of course. |
Thank you! |
π Linked issue
β Type of change
π Description
This PR saves the app that is gotten through the runtimeConfig $resolve async function and is used in place of the current 3 calls, resulting in a ~99.1% increase in performance.
Benchmark results (tested with the smallest possible timeout of 0 ms which would, in real time, likely take longer than that):
π Checklist