New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(schema): use parallel promises #24771
Conversation
Run & review this pull request in StackBlitz Codeflow. |
Marking as draft while I'm checking to see if anything else can be parallelized |
Pretty sure that's everything. |
I still don't quite get why the tests are failing, I don't see any "unexpected token"... |
Ah I see, looking back at it. I could've sworn without parentheses was fine when I tested but I probably mistook it for something, my bad |
π Linked issue
#24734
β Type of change
π Description
Following the linked PR, @pi0 brought to my attention that we can use parallel promises, and indeed the benchmark shows a significant ~30% improvement in performance, so all credits of this PR are to him.
π Checklist