feat(nuxt): useRequestHeader utility
#24781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Marking this a draft to write the documentation and make any necessary changes. |
β Live Preview ready!
|
|
Should I also clarify in the docs that this is used as an abstraction of |
danielroe
reviewed
Dec 15, 2023
danielroe
reviewed
Dec 15, 2023
danielroe
reviewed
Dec 15, 2023
|
Sure, it would be good to point people to the upstream utility used π |
|
Thank you! Indeed it is useful to be able to get one specific header π |
Co-authored-by: Daniel Roe <daniel@roe.dev>
Co-authored-by: Damian GΕowala <damian.glowala.rebkow@gmail.com>
danielroe
approved these changes
Dec 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
The current request header retrival process of
useRequestHeadersis a bit unintuitive in situations that require reading headers. It doesn't make a lot of sense from a developmental standpoint as more often than not you would need only a single header, mostly for "reading" operations (I myself have a couple of such use cases, for example, authorization middleware).This PR provides that possibility to simplify and improve DX. With this a person could simply do
That being said, I would like to reiterate and clarify that this is not a replacement of
getRequestHeaders. This can be used to directly read header values when dealing with authorization related middleware for example, whereas getRequestHeaders can be used to proxy the headers and use them in API calls, due to its object return.π Checklist