Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(schema): introduce future and features namespace #24880

Merged
merged 10 commits into from Dec 25, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This introduces new features and future namespaces.

  • features is for turning on/off specific features within Nuxt that are meant (and will continue) to be configurable but are not experimental.
  • future is for early opting-in to new features that are expected to become default in a future (possibly major) version of the framework.

I've also moved inlineSSRStyles, noScripts, and typescriptBundlerResolution from the previous namespace to new namespace, with backwards compatibility (though type errors will be shown in user projects).

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

stackblitz bot commented Dec 23, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

nuxt-studio bot commented Dec 23, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
Nuxt Docs Edit on Studio β†—οΈŽ View Live Preview 66cfb0c

@github-actions github-actions bot added the 3.x label Dec 23, 2023
Copy link

codspeed-hq bot commented Dec 23, 2023

CodSpeed Performance Report

Merging #24880 will degrade performances by 34.94%

⚠️ No base runs were found

Falling back to comparing refactor/features (5d67a70) with main (1a9fb57)

Summary

⚑ 1 improvements
❌ 1 regressions
βœ… 6 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main refactor/features Change
⚑ minimal test fixture (types) 136.3 ms 42.7 ms Γ—3.2
❌ minimal test fixture 39.2 ms 60.3 ms -34.94%

@danielroe
Copy link
Member Author

Looks like this is might be a bug in untyped: 23e98be. cc: @pi0

@danielroe danielroe merged commit 32d2c99 into main Dec 25, 2023
36 checks passed
@danielroe danielroe deleted the refactor/features branch December 25, 2023 14:03
@github-actions github-actions bot mentioned this pull request Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant