Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): stop tracking suspense resolution if error in page/layout #25389

Merged
merged 2 commits into from Jan 23, 2024

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #22683

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

If an error was thrown in a page or layout, before Nuxt finished hydrating, Nuxt would never unset isHydrating, meaning a number of things wouldn't work as expected, including clearing the error before navigation. For example, clicking header link to home on https://unstorage.unjs.io/404.

This PR adds a hook to decrement the hydration count when app:error is called in the initial hydration phase of the app.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

Copy link

stackblitz bot commented Jan 23, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe merged commit 7e375b5 into main Jan 23, 2024
35 checks passed
@danielroe danielroe deleted the fix/error-hydrate branch January 23, 2024 12:31
@github-actions github-actions bot mentioned this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants