Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nuxt): in dev mode, don't add links to css files that have been inlined #25822

Merged
merged 7 commits into from Feb 16, 2024
Merged

fix(nuxt): in dev mode, don't add links to css files that have been inlined #25822

merged 7 commits into from Feb 16, 2024
+29 −1

Conversation

OnlyWick
Copy link
Contributor

fix #24932.

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@stackblitz StackBlitz
Copy link

stackblitz bot commented Feb 16, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@OnlyWick @danielroe
Update packages/nuxt/src/core/runtime/nitro/renderer.ts
968d288 
Co-authored-by: Daniel Roe <daniel@roe.dev>
@danielroe danielroe changed the title fix(nuxt): support for the ?inline query parameter for Vite version > 5.0 fix(nuxt): in dev mode, don't add links to css files that have been inlined Feb 16, 2024
@danielroe danielroe merged commit e817655 into nuxt:main Feb 16, 2024
35 checks passed
@github-actions github-actions bot mentioned this pull request Feb 16, 2024
Merged
@OnlyWick OnlyWick deleted the fix-#24932 branch February 17, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
3.x bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nuxt ignores Vite's ?inline option for CSS imports
2 participants
@OnlyWick @danielroe