Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nuxt): in dev mode, don't add links to css files that have been inlined #25822

Merged
merged 7 commits into from Feb 16, 2024
Merged

fix(nuxt): in dev mode, don't add links to css files that have been inlined #25822

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e267109
fix(nuxt): support for the ?inline query parameter for Vite version >…
OnlyWick Feb 16, 2024
968d288
Update packages/nuxt/src/core/runtime/nitro/renderer.ts
OnlyWick Feb 16, 2024
5a23380
Update packages/nuxt/src/core/runtime/nitro/renderer.ts
OnlyWick Feb 16, 2024
231e1dc
fix: use `getQuery` from `ufo`
danielroe Feb 16, 2024
bf00f33
docs: add some comments
danielroe Feb 16, 2024
f434d7b
test: add basic test case
danielroe Feb 16, 2024
852c715
Merge branch 'main' into fix-#24932
OnlyWick Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/nuxt/src/core/runtime/nitro/renderer.ts
View file
Open in desktop
Expand Up @@ -393,6 +393,9 @@ export default defineRenderHandler(async (event): Promise<Partial<RenderResponse
for (const style in styles) {
const resource = styles[style]
if (!import.meta.dev || !isRenderingIsland || (resource.file.includes('scoped') && !resource.file.includes('pages/'))) {
// support for the ?inline query parameter for Vite version > 5.0
if (import.meta.dev && resource.file.endsWith('?inline')) continue
OnlyWick marked this conversation as resolved.
Show resolved Hide resolved

link.push({ rel: 'stylesheet', href: renderer.rendererContext.buildAssetsURL(resource.file) })
}
}
Expand Down