Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple policy support for Content-Security-Policy #2736

Merged
merged 6 commits into from Feb 5, 2018

Conversation

dojineko
Copy link

@dojineko dojineko commented Feb 1, 2018

this PR make it possible to set multiple policies on CSP. (default-src, object-src, etc...)
e.g.) default-src 'none'; script-src 'self' 'sha-256:...' https://exmaple.test

see also: https://developer.mozilla.org/en-US/docs/Web/HTTP/CSP

and, still remains csp.allowedSources ;)

refs:

@codecov-io
Copy link

codecov-io commented Feb 1, 2018

Codecov Report

Merging #2736 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #2736      +/-   ##
==========================================
+ Coverage   99.91%   99.91%   +<.01%     
==========================================
  Files          23       23              
  Lines        1211     1225      +14     
==========================================
+ Hits         1210     1224      +14     
  Misses          1        1
Impacted Files Coverage Δ
lib/common/options.js 100% <ø> (ø) ⬆️
lib/core/middleware/nuxt.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1582df1...1fd52e8. Read the comment docs.

@dojineko dojineko force-pushed the variable-csp branch 2 times, most recently from feebd6a to f9b757b Compare February 2, 2018 01:43
@dojineko
Copy link
Author

dojineko commented Feb 5, 2018

@pi0 hello :) could you please review this?

@Atinux Atinux merged commit 6acd9b6 into nuxt:dev Feb 5, 2018
@Atinux
Copy link
Member

Atinux commented Feb 5, 2018

Wow! This is a great PR! Thank you @dojineko

@dojineko dojineko deleted the variable-csp branch February 5, 2018 08:26
@dojineko
Copy link
Author

dojineko commented Feb 5, 2018

@Atinux thx!

@dojineko
Copy link
Author

dojineko commented Mar 5, 2018

@qm3ster
oops, it's no longer necessary shallow-copy.
thx for ur feedback. it will be fix it on #2945

@lock
Copy link

lock bot commented Nov 1, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 1, 2018
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants