Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nuxt)!: remove __NUXT__ after hydration #27745

Merged
merged 7 commits into from
Jun 26, 2024
Merged

fix(nuxt)!: remove __NUXT__ after hydration #27745

merged 7 commits into from
Jun 26, 2024

Conversation

danielroe
Copy link
Member

馃敆 Linked issue

resolves #25336

馃摎 Description

This removes window.__NUXT__ after app initialises. The payload can still be accessed with useNuxtApp().payload

馃憠 Migration

- console.log(window.__NUXT__)
+ console.log(useNuxtApp().payload)

@danielroe danielroe requested a review from manniL June 20, 2024 15:51
@danielroe danielroe self-assigned this Jun 20, 2024
@stackblitz StackBlitz
Copy link

stackblitz bot commented Jun 20, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe merged commit 5f819ab into main Jun 26, 2024
39 of 40 checks passed
@danielroe danielroe deleted the fix/remove-nuxt branch June 26, 2024 10:32
@github-actions github-actions bot mentioned this pull request Jun 26, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manniL manniL manniL approved these changes

@Atinux Atinux Atinux approved these changes

@ivomarsan ivomarsan ivomarsan approved these changes

Assignees

@danielroe danielroe

Labels
3.x 4.x 鈿狅笍 breaking change bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove window.__NUXT__ once app initialises
4 participants
@danielroe @manniL @Atinux @ivomarsan