allow publicPath in dev mode and do not automatically set nuxtStatic

[cj]

This refers to #25 and will allow you to use CDN's like cloudfront by setting the build.publicPath, it will also allow you to use nuxt with platforms like cordova because in dev mode you need to point to the full internal ip path like http://${host}:${port}/_nuxt/ to run on emulators or connected devices.

[codecov-io]

Codecov Report

Merging #279 into 0.9.10 will increase coverage by 0.7%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           0.9.10   #279     +/-   ##
=======================================
+ Coverage   99.29%   100%   +0.7%     
=======================================
  Files          11     11             
  Lines         426    422      -4     
=======================================
- Hits          423    422      -1     
+ Misses          3      0      -3

Impacted Files	Coverage Δ
lib/build.js	100% <ø> (+1.52%)	✅

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00c9abb...4c8d364. Read the comment docs.

[Atinux]

Why removing the ternary? If the public path is /app/ and router.base is /my-site/, publicPath should be /app/my-site/

[cj]

@Atinux with the current code urlJoin(self.options.router.base, self.options.build.publicPath) wouldn't that end up being /my-site/app/ which is wrong?

The html files this variable is for rendering are the files generated by webpack and not handling the inner routes of the app. So in my opinion, the router.base shouldn't come into play.

[cj]

[cj]

@Atinux this does lead into a bigger question I had when going through publicPath code, I think it becomes confusing mixing it in with router.base, as that is to do with vue-router and it will still work no matter the webpack.output.publicPath. I also think publicPath should not include /_nuxt/ but /_nuxt/ should be its own config variable like nuxtPath. I think these changes would lead to cleaner code, configs and less confusion. Let me know your thoughts. I'll work on a draft today, which I'll update this pull request with.

[Atinux]

@cj actually, when you want to host your application made with nuxt generate and hosted on github on this url: https://atinux.github.io/my-project/

1. The router.base needs to be /my-project/
2. The publicPath needs to be /my-project/_nuxt/ otherwise it won't fetch the required resources.

[Atinux]

Hi @cj

I implemented in the next release.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.