Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint: Prefer const over let #3650

Merged
merged 1 commit into from
Aug 8, 2018
Merged

Conversation

manniL
Copy link
Member

@manniL manniL commented Aug 8, 2018

Yes, after #3630 this is another consistent code style PR. To make the code more uniform, I'd suggest preferring const over let. Also, you know then that those variables will never be reassigned.

In the end, it's a matter of opinions again, it'd be also fine to go for let over const.

@codecov-io
Copy link

codecov-io commented Aug 8, 2018

Codecov Report

Merging #3650 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #3650   +/-   ##
=======================================
  Coverage   99.19%   99.19%           
=======================================
  Files          18       18           
  Lines        1123     1123           
  Branches      302      302           
=======================================
  Hits         1114     1114           
  Misses          9        9
Impacted Files Coverage Δ
lib/builder/webpack/base.js 100% <100%> (ø) ⬆️
lib/builder/builder.js 100% <100%> (ø) ⬆️
lib/builder/generator.js 94.23% <100%> (ø) ⬆️
lib/builder/webpack/utils/postcss.js 100% <100%> (ø) ⬆️
lib/core/nuxt.js 98.82% <100%> (ø) ⬆️
lib/common/utils.js 100% <100%> (ø) ⬆️
lib/core/middleware/error.js 97.56% <100%> (ø) ⬆️
lib/core/renderer.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 823c298...ae2d583. Read the comment docs.

Copy link
Member

@clarkdo clarkdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manniL manniL requested a review from Atinux August 8, 2018 10:32
@Atinux Atinux merged commit 52d9629 into nuxt:dev Aug 8, 2018
@Atinux
Copy link
Member

Atinux commented Aug 8, 2018

Nice, our Eslintrc is becoming better and better now!

@manniL manniL deleted the eslint-prefer-const branch August 8, 2018 10:58
@lock
Copy link

lock bot commented Oct 31, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 31, 2018
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants