Isolate client and server artifacts

[ishitatsuyuki]

Preliminary work for #2517.

[codecov-io]

Codecov Report

Merging #3758 into dev will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##              dev   #3758      +/-   ##
=========================================
- Coverage   97.92%   97.9%   -0.02%     
=========================================
  Files          18      18              
  Lines        1158    1147      -11     
  Branches      311     309       -2     
=========================================
- Hits         1134    1123      -11     
  Misses         23      23              
  Partials        1       1

Impacted Files	Coverage Δ
lib/builder/webpack/client.js	96.15% <ø> (ø)	⬆️
lib/builder/webpack/base.js	98.21% <ø> (ø)	⬆️
lib/core/middleware/error.js	97.56% <ø> (ø)	⬆️
lib/builder/generator.js	93.93% <100%> (-0.3%)	⬇️
lib/builder/builder.js	96.87% <100%> (+0.01%)	⬆️
lib/core/renderer.js	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97910de...88b6a13. Read the comment docs.

[clarkdo]

LGTM
How about to extract dist server and client into options.js?

[ishitatsuyuki]

I have considered making these directories configurable, however it adds considerable complexity and I'm not sure it has an use case.

[clarkdo]

I don’t think it’s worth making them configurable for now either, what I mean is adding variables in option, so that we only need to resolve one time.

[ishitatsuyuki]

Regarding putting it to options.js: I don't think that's necessary because it's resolved only a few times (across components), and putting it into another file may make the code harder to navigate.

[ishitatsuyuki]

@pi0 @Atinux Review ping!

[pi0]

That's a Breaking change for CDN deployments but great improvement @ishitatsuyuki 👍

[galvez]

@pi0 can you elaborate on why it breaks CDN deployment? You mean when we set build.publicPath? BTW, nice to see you!

[clarkdo]

Correct, we need to update document, user should upload dist/client to cdn.

[galvez]

@clarkdo like this? nuxt/docs#719

[clarkdo]

Yes and maybe also release notes @Atinux

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.