feat: new filenames structure #3789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
clarkdo
commented
Aug 22, 2018
•
clarkdo
commented
- Update document
Codecov Report
@@ Coverage Diff @@
## dev #3789 +/- ##
==========================================
- Coverage 97.84% 97.76% -0.08%
==========================================
Files 18 18
Lines 1159 1165 +6
Branches 312 318 +6
==========================================
+ Hits 1134 1139 +5
- Misses 24 25 +1
Partials 1 1
Continue to review full report at Codecov.
|
pi0
reviewed
Aug 22, 2018
lib/common/nuxt.config.js
Outdated
| font: 'fonts/[name].[hash:7].[ext]', | ||
| video: 'videos/[name].[hash:7].[ext]' | ||
| // { isDev, isClient, isServer } | ||
| app: ({ isDev }) => isDev ? '[path][name].js' : '[contenthash].js', |
There was a problem hiding this comment.
Can we use chunkhash for app and chunk?
pi0
approved these changes
Aug 22, 2018
Atinux
reviewed
Aug 22, 2018
lib/builder/webpack/base.js
Outdated
| } | ||
| return this.normalizeFileName(fileName) | ||
| if (this.options.dev) { |
There was a problem hiding this comment.
What about if (this.options.dev && /\[(chunkhash|contenthash|hash)(?::(\d+))?\]/.test(fileName))?
|
@clarkdo Is it included in the 2.0 docs yet? 🤔 |
|
@clarkdo Thank you |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.