Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): list commands #4245

Merged
merged 25 commits into from Nov 1, 2018
Merged

feat(cli): list commands #4245

merged 25 commits into from Nov 1, 2018

Conversation

galvez
Copy link

@galvez galvez commented Oct 31, 2018

@pi0 go wild :)

screen shot 2018-10-31 at 6 10 15 pm

@galvez galvez requested a review from pi0 October 31, 2018 20:10
@galvez galvez self-assigned this Oct 31, 2018
manniL
manniL previously approved these changes Oct 31, 2018
@codecov-io
Copy link

codecov-io commented Oct 31, 2018

Codecov Report

Merging #4245 into dev will decrease coverage by 1.05%.
The diff coverage is 43.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4245      +/-   ##
==========================================
- Coverage   94.04%   92.98%   -1.06%     
==========================================
  Files          50       51       +1     
  Lines        1678     1696      +18     
  Branches      436      438       +2     
==========================================
- Hits         1578     1577       -1     
- Misses         97      116      +19     
  Partials        3        3
Impacted Files Coverage Δ
packages/cli/src/utils.js 80.64% <ø> (-3.08%) ⬇️
packages/cli/src/run.js 39.39% <5.88%> (-35.61%) ⬇️
packages/cli/src/command.js 91.04% <60%> (-1.71%) ⬇️
packages/cli/src/formatting.js 80% <80%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6e6ded...5fc854f. Read the comment docs.

pi0
pi0 previously approved these changes Oct 31, 2018
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than fmt tree shaking issue, LGTM

@@ -1,12 +1,9 @@
import parseArgs from 'minimist'
import { name, version } from '../package.json'
import { loadNuxtConfig, indent, foldLines } from './utils'
import { loadNuxtConfig } from './utils'
import * as fmt from './formatting'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This type of import prevents tree-shaking utils

@galvez galvez dismissed stale reviews from pi0 and manniL via 5979244 November 1, 2018 00:19
@Atinux Atinux merged commit 6dadadf into dev Nov 1, 2018
@Atinux Atinux deleted the cli/list-commands branch November 1, 2018 03:53
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants