Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add help command #4248

Merged
merged 14 commits into from
Nov 2, 2018
Merged

feat(cli): add help command #4248

merged 14 commits into from
Nov 2, 2018

Conversation

galvez
Copy link

@galvez galvez commented Nov 1, 2018

Following convention used in vue and other tools like kubectl (Kubernetes).

nuxt help <command>

@pi0 still need to add tests, but welcome early feedback as usual :)

@galvez galvez added the WIP label Nov 1, 2018
@galvez galvez self-assigned this Nov 1, 2018
@galvez galvez requested review from Atinux and pi0 November 1, 2018 05:17
@codecov-io
Copy link

codecov-io commented Nov 1, 2018

Codecov Report

Merging #4248 into dev will decrease coverage by 0.58%.
The diff coverage is 38.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4248      +/-   ##
==========================================
- Coverage   92.98%   92.39%   -0.59%     
==========================================
  Files          51       52       +1     
  Lines        1696     1710      +14     
  Branches      438      442       +4     
==========================================
+ Hits         1577     1580       +3     
- Misses        116      124       +8     
- Partials        3        6       +3
Impacted Files Coverage Δ
packages/cli/src/commands/help.js 0% <0%> (ø)
packages/cli/src/commands/index.js 100% <100%> (ø) ⬆️
packages/cli/src/run.js 35.48% <60%> (-3.92%) ⬇️
packages/cli/src/command.js 90.27% <80%> (-0.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9b63de...29b1106. Read the comment docs.

packages/cli/src/run.js Outdated Show resolved Hide resolved
packages/cli/src/command.js Outdated Show resolved Hide resolved
@galvez galvez removed the WIP label Nov 1, 2018
@Atinux Atinux merged commit 19287cc into dev Nov 2, 2018
@Atinux Atinux deleted the cli/help-command branch November 2, 2018 04:35
@lock
Copy link

lock bot commented Dec 2, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 2, 2018
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants