Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): don't accept ranges #4295

Merged
merged 2 commits into from Nov 8, 2018
Merged

feat(server): don't accept ranges #4295

merged 2 commits into from Nov 8, 2018

Conversation

manniL
Copy link
Member

@manniL manniL commented Nov 8, 2018

Resolves #3870

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-io
Copy link

codecov-io commented Nov 8, 2018

Codecov Report

Merging #4295 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev    #4295      +/-   ##
=========================================
+ Coverage   90.9%   90.91%   +<.01%     
=========================================
  Files         56       56              
  Lines       1804     1805       +1     
  Branches     450      450              
=========================================
+ Hits        1640     1641       +1     
  Misses       153      153              
  Partials      11       11
Impacted Files Coverage Δ
packages/server/src/middleware/nuxt.js 98.55% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc00980...150dd4a. Read the comment docs.

@pi0 pi0 merged commit f5bf24a into dev Nov 8, 2018
@pi0 pi0 deleted the feat-dont-accept-ranges branch November 8, 2018 18:43
@lock
Copy link

lock bot commented Dec 8, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 8, 2018
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't honor Range header by default
4 participants